Spending trusts its own ledger: gifts read persisted ark state, and Savings keeps its pending line to itself

Co-Authored-By: Claude Fable 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01M5kFodm9azZJVTQxnkDdKe

2 files changed, 16 insertions, 3 deletions

diff --git a/src/features/ark.js b/src/features/ark.js
index 2fa151f..1a5a2a2 100644
--- a/src/features/ark.js
+++ b/src/features/ark.js
@@ -2044,9 +2044,14 @@ export function arkFeature(ctx) {
 
     // ---- ark-gift hooks (called by the gifts feature via ctx.hook) ----
     arkGiftInfo() {
-      if (!arkAvailable() || !ark || !ark.state) return null;
+      // Persisted state, not the live manager: the gift form renders before
+      // connectArk() has run, and a null here silently flips the gift to the
+      // on-chain source — "more than your balance" against Savings while the
+      // header shows a healthy Spending balance. Creation connects on demand.
+      const b = arkAvailable() ? arkBalance() : null;
+      if (!b) return null;
       maybeReconcile(); // the gift form is a send-intent signal too (throttled)
-      return { spendableSat: ark.balance().spendableSat };
+      return { spendableSat: b.spendableSat, pendingSat: b.pendingSat };
     },
     arkGiftDecode(code) { return decodeArkGiftCode(code); },
     // A fresh visitor (no wallets) opening a gift link lands on the gift's
diff --git a/src/features/gifts.js b/src/features/gifts.js
index 0543030..e3025d3 100644
--- a/src/features/gifts.js
+++ b/src/features/gifts.js
@@ -412,7 +412,15 @@ export function giftsFeature(ctx) {
     const avail = info ? info.spendableSat : 0;
     const amt = ui.giftMax ? avail : parseAmount(ui.giftAmount, getUnit());
     if (!amt || amt < 1) { ui.giftError = t('giftAmountInvalid', { n: fmtAmount(1) + ' ' + unitLabel() }); render(); return; }
-    if (amt > avail) { ui.giftError = t('giftExceedsBalance'); render(); return; }
+    if (amt > avail) {
+      // The headline Spending number includes settling coins; when those are
+      // what's missing, say so instead of disputing the user's own balance.
+      const pend = (info && info.pendingSat) || 0;
+      ui.giftError = amt <= avail + pend
+        ? t('giftSettling', { n: fmtAmount(pend) + ' ' + unitLabel() })
+        : t('giftExceedsBalance');
+      render(); return;
+    }
     ui.busy = true; ui.giftError = ''; render();
     try {
       const g = await hook('arkGiftCreate', amt);