Media grids: one tile for a clip uploaded twice, and a picture that won't load stays outHEADmaster

- Videos: one person's clips of one size to the byte are one clip. Beatbox
  Serenade posted the same video as a note and as a video event, each
  upload a fresh Blossom hash, so neither the file nor the words matched.
  Only a size the post or the host states counts (a bitrate x duration
  guess is marked sizeGuess and never matched).
- Images: a picture whose load failed was hidden by a class the next
  repaint rewrote, so the broken-picture glyph came back (a deleted
  nostr.media file in #artstr). Failed pictures are now remembered for the
  session and left out of the grid.
- A tile fetching its own frame froze the whole tile against repaints, so
  one built for the one-to-a-row layout never got its --ar in justified rows
  (zero width). Only the player and its stand-ins are frozen now; the
  render draws the cost badge itself. Tile pictures no longer size their
  tile (a frame-grab <video>'s 320px stretched its row).
- Test fixtures that served one file under several names (or one imeta
  size for every clip) now differ per clip.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01K5xtiFrkFVsrkWx6JDQjiT

1 files changed, 38 insertions, 12 deletions

diff --git a/tools/media-grid-dups-test.js b/tools/media-grid-dups-test.js
index 205a4a5..e7b67da 100644
--- a/tools/media-grid-dups-test.js
+++ b/tools/media-grid-dups-test.js
@@ -1,6 +1,8 @@
 // The Videos grid shows a clip once, however many posts carry it: the same
 // file (or a Blossom hash's mirror), or the same words from the same person
-// with a fresh upload (Adam, 2026-10-22). And on a big screen with a mouse, a
+// with a fresh upload, or the same file uploaded twice under two hashes (a
+// note and a video event: one size to the byte) (Adam, 2026-10-22). A picture
+// that won't load leaves the Images grid instead of a broken-picture glyph. And on a big screen with a mouse, a
 // small clip opened in the pager is drawn at most 1.5× its own pixels, not
 // blown up across the monitor. Run: bun tools/media-grid-dups-test.js
 import puppeteer from './puppeteer.js';
@@ -12,12 +14,18 @@ const sleep = (ms) => new Promise((r) => setTimeout(r, ms));
 let ok = true;
 const check = (n, c, d = '') => { console.log(` ${c ? '✓' : '✗'} ${n}${d ? ' — ' + d : ''}`); if (!c) ok = false; };
 const png = Bun.spawnSync(['ffmpeg', '-loglevel', 'error', '-f', 'lavfi', '-i', 'testsrc=size=320x180', '-frames:v', '1', '-f', 'image2', '-c:v', 'png', 'pipe:1']).stdout;
-const clip = (name, size) => {
-  const f = '/tmp/coinos-vpager-' + name + '.webm';
-  if (!existsSync(f)) Bun.spawnSync(['ffmpeg', '-y', '-loglevel', 'error', '-f', 'lavfi', '-i', 'testsrc=size=' + size + ':rate=10', '-t', '30', '-c:v', 'libvpx', '-b:v', '100k', f]);
+const clip = (name, size, t = 30) => {
+  const f = '/tmp/coinos-vpager-' + name + (t === 30 ? '' : '-' + t) + '.webm';
+  if (!existsSync(f)) Bun.spawnSync(['ffmpeg', '-y', '-loglevel', 'error', '-f', 'lavfi', '-i', 'testsrc=size=' + size + ':rate=10', '-t', String(t), '-c:v', 'libvpx', '-b:v', '100k', f]);
   return f;
 };
-const CLIPS = { wide: clip('wide', '320x180'), again: clip('wide', '320x180'), other: clip('wide', '320x180'), tall: clip('tall', '180x320'), last: clip('last', '240x240') };
+// (the re-uploaded post's files differ from the reposted one's: one size from
+// one person is taken for one file)
+const CLIPS = { wide: clip('wide', '320x180'), again: clip('wide', '320x180', 25), other: clip('wide', '320x180', 26), tall: clip('tall', '180x320'), last: clip('last', '240x240') };
+// the twice-uploaded clip: its own file (the ones above are all one file, so a
+// size match would take them for one clip too)
+const TWIN = '/tmp/coinos-vpager-twin.webm';
+if (!existsSync(TWIN)) Bun.spawnSync(['ffmpeg', '-y', '-loglevel', 'error', '-f', 'lavfi', '-i', 'testsrc=size=320x180:rate=10', '-t', '20', '-c:v', 'libvpx', '-b:v', '100k', TWIN]);
 const pic = (size) => Bun.spawnSync(['ffmpeg', '-loglevel', 'error', '-f', 'lavfi', '-i', 'testsrc=size=' + size, '-frames:v', '1', '-f', 'image2', '-c:v', 'png', 'pipe:1']).stdout;
 const picWide = pic('640x360'), picTall = pic('360x640');
 const SK = generateSecretKey(), AUTHOR = getPublicKey(SK);
@@ -25,16 +33,16 @@ const now = Math.floor(Date.now() / 1000);
 const html = await buildHtml({ minify: true, pwa: false });
 const server = Bun.serve({ port: 0, fetch: (req) => {
   const path = new URL(req.url).pathname;
-  const m = /^\/(wide|again|other|tall|last)\.webm$/.exec(path);
+  const m = /^\/(wide|again|other|tall|last|twina|twinb)\.webm$/.exec(path);
   if (m) {
-    const f = Bun.file(CLIPS[m[1]]), range = /^bytes=(\d+)-(\d*)$/.exec(req.headers.get('range') || '');
+    const f = Bun.file(CLIPS[m[1]] || TWIN), range = /^bytes=(\d+)-(\d*)$/.exec(req.headers.get('range') || '');
     if (!range) return new Response(f, { headers: { 'content-type': 'video/webm', 'accept-ranges': 'bytes' } });
     const a = +range[1], b = range[2] ? Math.min(+range[2], f.size - 1) : f.size - 1;
     return new Response(f.slice(a, b + 1), { status: 206, headers: { 'content-type': 'video/webm', 'accept-ranges': 'bytes', 'content-range': 'bytes ' + a + '-' + b + '/' + f.size, 'content-length': String(b - a + 1) } });
   }
   const pm = /^\/pic-(wide|tall)\.png$/.exec(path);
   if (pm) return new Response(pm[1] === 'wide' ? picWide : picTall, { headers: { 'content-type': 'image/png', 'access-control-allow-origin': '*' } });
-  if (path === '/dead.webm') return new Response('gone', { status: 404 });
+  if (path === '/dead.webm' || path === '/deadpic.png') return new Response('gone', { status: 404 });
   if (path === '/still.png') return new Response(png, { headers: { 'content-type': 'image/png' } });
   if (path.startsWith('/punks') || path === '/verify-worker.js') return new Response(Bun.file('dist' + path));
   return new Response(html, { headers: { 'content-type': 'text/html' } });
@@ -50,6 +58,12 @@ const seeded = [
   post('Transylvania lightning conference 2026 ' + U('again'), U('again'), 200),
   post('Transylvania lightning conference 2026 ' + U('other'), U('other'), 300),
   post('the last clip ' + U('last'), U('last'), 400),
+  // one person's clip twice, as a note and as a video event, a fresh hash
+  // each (the server stores it again): different words, same bytes
+  finalizeEvent({ kind: 1, created_at: now - 410, tags: [['imeta', 'url ' + U('twina'), 'm video/webm', 'dim 320x180', 'size ' + Bun.file(TWIN).size]], content: '#goodmorning another beat ' + U('twina') }, SK),
+  finalizeEvent({ kind: 22, created_at: now - 420, tags: [['imeta', 'url ' + U('twinb'), 'm video/webm', 'dim 320x180', 'size ' + Bun.file(TWIN).size], ['title', 'Random Beat']], content: 'Random Beat' }, SK),
+  // a picture its host has deleted
+  finalizeEvent({ kind: 1, created_at: now - 125, tags: [], content: 'gone now ' + server.url.origin + '/deadpic.png' }, SK),
   // pictures, one wide and one tall, the post saying nothing of their size
   finalizeEvent({ kind: 1, created_at: now - 120, tags: [], content: 'a wide view ' + server.url.origin + '/pic-wide.png' }, SK),
   finalizeEvent({ kind: 1, created_at: now - 130, tags: [], content: 'a tall view ' + server.url.origin + '/pic-tall.png' }, SK),
@@ -92,7 +106,8 @@ try {
   await page.reload({ waitUntil: 'domcontentloaded' });
   await waitText('receive', 20000);
   await page.evaluate(() => document.querySelector('.app-nav-button[aria-label="Feed"]').click());
-  check('the clips are in the feed', await waitFor(() => document.querySelectorAll('.notes-feed video.note-video').length >= 8, null, 20000));
+  // (the feed paints its first rows: seven of the clips' posts are among them)
+  check('the clips are in the feed', await waitFor(() => document.querySelectorAll('.notes-feed video.note-video').length >= 7, null, 20000), String(await page.evaluate(() => document.querySelectorAll('.notes-feed video.note-video').length)));
   await page.evaluate(() => document.querySelector('.media-mode[data-mode="videos"]').click());
   // a desktop-sized window starts on every shape (justified rows, the tall clip in)
   check('a desktop starts on every shape', await waitFor(() => !!document.querySelector('.media-grid.justified') && [...document.querySelectorAll('.media-grid .media-tile')].some((t) => t.getAttribute('data-key').endsWith('/tall.webm')), null, 15000));
@@ -100,12 +115,12 @@ try {
   await page.evaluate(() => { localStorage.setItem('coinos-clips-fit', 'fit'); document.querySelector('.media-mode[data-mode="images"]').click(); });
   await sleep(300);
   await page.evaluate(() => document.querySelector('.media-mode[data-mode="videos"]').click());
-  await waitFor(() => document.querySelectorAll('.media-grid .media-tile').length >= 3, null, 15000);
-  await waitFor(() => document.querySelectorAll('.media-grid .media-tile').length === 3, null, 8000);
+  await waitFor(() => document.querySelectorAll('.media-grid .media-tile').length >= 4, null, 15000);
+  await waitFor(() => document.querySelectorAll('.media-grid .media-tile').length === 4, null, 8000);
   await sleep(1500);
   const tiles = await page.evaluate(() => document.querySelectorAll('.media-grid .media-tile').length);
   check('a wide screen lays the clips out one to a row, wide', await page.evaluate(() => { const g = document.querySelector('.media-grid'), t = g.querySelector('.media-tile').getBoundingClientRect(); return g.classList.contains('wide') && Math.abs(t.width / t.height - 16 / 9) < 0.05 && t.width > g.getBoundingClientRect().width * 0.95; }));
-  check('one tile per clip: the reposted file once, the re-uploaded post once, the other one, none for the deleted one', tiles === 3, tiles + ' tiles');
+  check('one tile per clip: the reposted file once, the re-uploaded post once, the twice-uploaded file once, the other one, none for the deleted one', tiles === 4, tiles + ' tiles: ' + (await page.evaluate(() => [...document.querySelectorAll('.media-grid .media-tile')].map((t) => t.getAttribute('data-key').split('/').pop()).join(' '))));
   await page.evaluate(() => document.querySelector('.media-grid .media-tile').click());
   check('the pager opens', await waitFor(() => !!document.querySelector('.mp-slide.mp-cur video.mp-media'), null, 6000));
   check('the clip is drawn no bigger than 1.5× its pixels', await waitFor(() => { const v = document.querySelector('.mp-slide.mp-cur video.mp-media'); return v && v.videoWidth && v.getBoundingClientRect().width <= v.videoWidth * 1.5 + 1 && v.style.maxWidth; }, null, 8000),
@@ -134,6 +149,17 @@ try {
   const picAr = (name) => page.evaluate((n) => { const t = [...document.querySelectorAll('.media-grid .media-tile')].find((x) => x.getAttribute('data-key').endsWith(n)); if (!t) return null; const r = t.getBoundingClientRect(); return +(r.width / r.height).toFixed(2); }, name);
   check('the Images grid lays pictures out in justified rows, each its own shape', await waitFor(() => { const g = document.querySelector('.media-grid.justified'); if (!g) return false; const ar = (n) => { const t = [...g.querySelectorAll('.media-tile')].find((x) => x.getAttribute('data-key').endsWith(n)); if (!t) return 0; const r = t.getBoundingClientRect(); return r.width / r.height; }; return Math.abs(ar('pic-wide.png') - 16 / 9) < 0.05 && Math.abs(ar('pic-tall.png') - 9 / 16) < 0.05; }, null, 10000),
     JSON.stringify({ wide: await picAr('pic-wide.png'), tall: await picAr('pic-tall.png') }));
+  // the deleted picture: gone from the grid, and still gone after repaints
+  // (they rewrite each tile's class list)
+  await sleep(1500);
+  await page.evaluate(() => { document.querySelector('.media-mode[data-mode="videos"]').click(); });
+  await sleep(300);
+  await page.evaluate(() => { document.querySelector('.media-mode[data-mode="images"]').click(); });
+  await sleep(1500);
+  check('a picture that won\'t load leaves the grid for good', await page.evaluate(() => {
+    const ts = [...document.querySelectorAll('.media-grid .media-tile')];
+    return ts.length >= 2 && !ts.some((t) => t.getAttribute('data-key').endsWith('deadpic.png') && getComputedStyle(t).display !== 'none');
+  }), await page.evaluate(() => [...document.querySelectorAll('.media-grid .media-tile')].map((t) => t.getAttribute('data-key').split('/').pop() + (getComputedStyle(t).display === 'none' ? '(hidden)' : '')).join(' ')));
   check('no page errors', errs.length === 0, errs.slice(0, 2).join(' | '));
 } finally {
   await browser.close();