From 572361e2bd1ab16b4618517c2d9531689c6f46a8 Mon Sep 17 00:00:00 2001 From: Adam Soltys Date: Sat, 10 Oct 2026 07:03:30 -0700 Subject: Messages: NIP-42 inbox relays. isolabellart's kind-10050 inbox is auth.nostr1.com and a personal relay, both of which answer a REQ for their gift wraps with CLOSED "auth-required" — we never authenticated, so DMs delivered only there (anything sent from Amethyst and other 10050-only clients) never reached v3. The DM subscription on our own inbox relays now authenticates as the DM identity (subscribeAuthed: per relay, AUTH then ask again, still closable; the AUTH event is signed before nostr-tools' cached auth promise so a failing signer can't wedge the socket), sends to a peer's inbox authenticate when a relay refuses the write with auth-required, and our sent copy also goes to our own inbox relays so other clients reading that list see it. Never Amber by intent (an app trip per connection). Checked live: auth.nostr1.com accepts the handshake. tools/dm-nip42-test.js MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01Vps2H27rhbG9ZqseGfMrc3 --- src/features/messages.js | 36 +++++++++++++++++++++++++++++++----- 1 file changed, 31 insertions(+), 5 deletions(-) (limited to 'src/features') diff --git a/src/features/messages.js b/src/features/messages.js index 597cb23..4512818 100644 --- a/src/features/messages.js +++ b/src/features/messages.js @@ -13,7 +13,7 @@ // listens for both identities and decrypts with whichever keys are present. import { - subscribeOn, publishOn, queryOn, queryManyOn, queryStreamOn, fetchInboxRelays, relayAlive, liveRelayList, readRelayList, resetRelay, + subscribeOn, subscribeAuthed, publishOn, queryOn, queryManyOn, queryStreamOn, fetchInboxRelays, relayAlive, liveRelayList, readRelayList, resetRelay, npubOf, neventOf, parseNostrPubkey, parseNostrRef, generateSecretKey, getPublicKey, finalizeEvent, nip44, PROFILE_RELAYS, openWrapsOffthread, unwrapDMsOffthread, verifyEventsAsync, setSyncConfig, DEFAULT_SYNC_RELAYS, } from '../nostr.js'; @@ -514,6 +514,22 @@ export function messagesFeature(ctx) { if (wallet.nostr && wallet.nostr.sk) return { pubkey: wallet.nostr.pk, signer: wallet.nostr.sk }; return null; } + // NIP-42: sign a relay's AUTH challenge as the DM identity — an inbox + // relay (auth.nostr1.com, a personal relay) shows gift wraps only to the + // pubkey they're for, and some take writes only from authenticated users. + // Never Amber by intent: an app trip per relay connection, for a read + // nobody asked for. + async function relayAuth(tmpl) { + const id = await identity(); + if (!id) throw new Error('no identity'); + if (id.signer instanceof Uint8Array) return finalizeEvent(tmpl, id.signer); + if (id.signer.interactive) throw new Error('signer is interactive'); + return id.signer.signEvent(tmpl); + } + // Our own kind-10050 inbox beyond DM_RELAYS (read at startDMs): sent + // copies go there too, so other clients reading that list see them. + let ownInbox = []; + const toOwnInbox = (wrap) => { if (ownInbox.length) publishOn(ownInbox, wrap, { onauth: relayAuth }); }; // what a feed or a profile lists: notes, and polls (NIP-88) const FEED_KINDS = [1, 1068]; // A profile shows its articles (NIP-23) among the notes, as Amethyst does. @@ -3118,7 +3134,14 @@ export function messagesFeature(ctx) { // them (crypticCypher's replies reached only primal, the 4th extra // in Adam's list, while a cap of three read the first three) .slice(0, 8); - if (extras.length && dmStarted) dmSub(extras); + ownInbox = extras; + // inbox relays are often NIP-42 gated: authenticate as the identity + if (extras.length && dmStarted) { + const u = subscribeAuthed(extras, { kinds: [1059], '#p': pks, limit: 400 }, (wrap) => { + handleInboxWrap(wrap).catch(() => {}); + }, { onauth: relayAuth, onclose: noteSubClosed }); + allUnsubs.push(u); dmUnsubs.push(u); + } } catch {} })(); ensureDmRelayList().catch(() => {}); @@ -3173,9 +3196,10 @@ export function messagesFeature(ctx) { // Publishing the same wrap twice is harmless — relays dedupe on id. const ok = await publishOn(DM_RELAYS, toPeer); publishOn(DM_RELAYS, toSelf); + toOwnInbox(toSelf); fetchInboxRelays(peer).then((inbox) => { const extra = inbox.slice(0, 4).filter((r) => !DM_RELAYS.includes(r)); - if (extra.length) publishOn(extra, toPeer); + if (extra.length) publishOn(extra, toPeer, { onauth: relayAuth }); }).catch(() => {}); if (!ok) { toast(t('msgSendFailed')); return; } delete entry.pending; @@ -3209,9 +3233,10 @@ export function messagesFeature(ctx) { seenWraps.add(toPeer.id); seenWraps.add(toSelf.id); const ok = await publishOn(DM_RELAYS, toPeer); publishOn(DM_RELAYS, toSelf); + toOwnInbox(toSelf); fetchInboxRelays(peer).then((inbox) => { const extra = inbox.slice(0, 4).filter((x) => !DM_RELAYS.includes(x)); - if (extra.length) publishOn(extra, toPeer); + if (extra.length) publishOn(extra, toPeer, { onauth: relayAuth }); }).catch(() => {}); if (!ok) toast(t('msgSendFailed')); } catch (e) { @@ -8020,9 +8045,10 @@ export function messagesFeature(ctx) { const toSelf = await wrapDM(id.signer, id.pubkey, rumor); const ok = await publishOn(DM_RELAYS, toPeer); publishOn(DM_RELAYS, toSelf); + toOwnInbox(toSelf); fetchInboxRelays(peer).then((inbox) => { const extra = inbox.slice(0, 4).filter((r) => !DM_RELAYS.includes(r)); - if (extra.length) publishOn(extra, toPeer); + if (extra.length) publishOn(extra, toPeer, { onauth: relayAuth }); }).catch(() => {}); if (!ok) { threadOf(peer).delete(rumor.id); toast(t('msgSendFailed')); render(); return; } delete entry.pending; -- cgit v1.2.3