From 83aa57add3be62cb38acb1612ff6257a2996972f Mon Sep 17 00:00:00 2001 From: Adam Soltys Date: Mon, 28 Sep 2026 09:46:57 -0700 Subject: A clip the reader turned the sound on for stays loud for the session, however its box is rebuilt. Pinning the box only protected it from a patch in place. A repaint that pairs children differently, the window unmounting the row and mounting it again, or a quoted note loading all rebuilt the player muted with the button back; the URL is remembered now, and a rebuilt box starts loud with no button. Muting again from the player's own control forgets it. Co-Authored-By: Claude Fable 5.1 Claude-Session: https://claude.ai/code/session_01VhUKyXKtsJ67QAFfb7QR9D --- src/features/messages.js | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) (limited to 'src/features') diff --git a/src/features/messages.js b/src/features/messages.js index f57c3ee..945f01e 100644 --- a/src/features/messages.js +++ b/src/features/messages.js @@ -5087,21 +5087,32 @@ export function messagesFeature(ctx) { } // An inline video, in a box with the sound button; plays on its own while // on screen. Once it has played, the box is the viewer's (no morph). + // A clip the reader turned the sound on for stays that way for the session, + // however its box is rebuilt: a repaint pairing children differently, the + // window unmounting the row and mounting it again, a quoted note loading. + // Pinning the box alone left every one of those a muted restart. + const unmutedClips = new Set(); function videoNode(url, { stable = false } = {}) { + const loud = unmutedClips.has(url); const v = h('video', { src: url, class: 'note-video', controls: true, - preload: 'metadata', playsinline: true, muted: true, // play() in view fetches; a window of videos must not all stream + preload: 'metadata', playsinline: true, muted: loud ? undefined : true, // play() in view fetches; a window of videos must not all stream style: stable ? 'width:100%;aspect-ratio:16/9;object-fit:contain' : undefined, onError: (e) => { if (!stable) { const b = e.target.parentElement; if (b) b.style.display = 'none'; } } }); - v.muted = true; // the property, not just the attribute: a script-made element autoplays only muted + v.muted = !loud; // the property, not just the attribute: a script-made element autoplays only muted const box = h('div', { class: 'note-video-box' }, v); - const btn = soundBtn(() => { + if (loud) box._skipMorph = true; + const btn = loud ? null : soundBtn(() => { v.muted = false; + unmutedClips.add(url); box._skipMorph = true; // the box is the viewer's now: no repaint rebuilds it muted if (v.paused) v.play().catch(() => {}); btn.remove(); // the player's own controls carry mute from here }); - v.onvolumechange = () => { if (!v.muted && btn.isConnected) btn.remove(); }; // unmuted from the native control: same - box.append(btn); + v.onvolumechange = () => { + if (!v.muted) { unmutedClips.add(url); if (btn && btn.isConnected) btn.remove(); } // unmuted from the native control: same + else unmutedClips.delete(url); // muted again from the control: the next box starts quiet + }; + if (btn) box.append(btn); // Off screen, a muted preview lets go of its media entirely (a paused // player keeps buffering the whole file — a scroll past ten clips // streamed seventy megabytes); back in view it reattaches and plays -- cgit v1.2.3