diff options
| author | Adam Soltys <[email protected]> | 2026-05-25 12:56:16 -0700 |
|---|---|---|
| committer | Adam Soltys <[email protected]> | 2026-05-25 12:56:16 -0700 |
| commit | caebad1dd85188f4315751c6ce77f92d7a1588c2 (patch) | |
| tree | 74a1e11a68cc88fc7fb59e63cb5830d1cf716893 /lib/upload.ts | |
| parent | 8aba0bc2e3b5d09b3783b87eb0a29088b40796e4 (diff) | |
| download | coinos-server-caebad1dd85188f4315751c6ce77f92d7a1588c2.tar.gz coinos-server-caebad1dd85188f4315751c6ce77f92d7a1588c2.zip | |
sendLightning: stop warning on healthy multi-path payments
Each xpay with failed_parts > 0 that ultimately settled (multi-path
retry — common, not concerning) was firing 3 WARN lines:
"xpay returned (abnormal)"
"xpay returned failed_parts without throwing"
"xpay failed_parts but listpays complete — finalizing"
These are all the SAME successful payment. The presence of failed_parts
just means CLN tried multiple paths before one succeeded. Adam was
seeing noise.
Now:
- Only warn on actually-missing preimage (xpay silently failed).
- Drop the unconditional "without throwing" warn — the failed_parts
branch handles the recovery silently in the success case.
- Drop the "listpays complete — finalizing" warn — that's the success
path, not a concern.
- KEEP warns for the genuinely interesting cases: listpays says failed
(we're about to reverse), listpays says pending (debit left for
check() to reconcile), or finalize itself throws.
Net effect: a healthy multi-path payment now emits only the standard
"sendLightning outcome <id> = finalized-via-listpays-after-failed_parts"
info line instead of 3 WARN lines.
Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
Diffstat (limited to 'lib/upload.ts')
0 files changed, 0 insertions, 0 deletions
