aboutsummaryrefslogtreecommitdiffstats
path: root/lib/webhooks.ts
diff options
context:
space:
mode:
authorAdam Soltys <[email protected]>2026-09-13 20:44:48 -0700
committerAdam Soltys <[email protected]>2026-09-13 20:44:48 -0700
commitd8a361bdcfaa8cc5b39d9675e74b0e1d2e42be2c (patch)
tree9709aa57f0e9138a23fef25ae3cb528e4c30068f /lib/webhooks.ts
parent287fdb2b14b48d769e43a223c5c33049ff470880 (diff)
downloadcoinos-server-d8a361bdcfaa8cc5b39d9675e74b0e1d2e42be2c.tar.gz
coinos-server-d8a361bdcfaa8cc5b39d9675e74b0e1d2e42be2c.zip
security: drop the admin endpoint surface and land pending hardening
Removes the admin-gated endpoints and the account flags they set, plus a batch of hardening that had accumulated uncommitted in the tree. These were deployed and verified together, so they land as one change. admin surface: - drop POST /hidepay, POST /unlimit and GET /users, their handlers, and the now-unused admin preValidation export - `unlimited` was only ever written, never read; `hidepay` only appeared in output projections. Both flags go, along with their whitelist, public-fields and type entries. request log: - redactBody now recurses. It only masked top-level keys, so a body that nests credentials one level down wrote them to the log in plaintext, and pin fields were not on the list at all. payments: - sendOnchain/build gate `aid` through requireAccount, so a caller can only spend from an account it owns - sendOnchain signs only a tx we composed, matched against a short-lived per-account build receipt - raise xpay retry_for to 60s; route-finding preferred a drained zero-fee hop and burned the whole budget on it. check()'s reversal window keeps its 2x margin. ecash / invoices / webhooks: - resolve a token's mint through the IP-pinning fetcher instead of plain fetch, closing an unauthenticated SSRF path into the internal network - reject non-positive amounts before the balance write - /sign requires the caller to own the address, rather than signing under any address the hot wallet controls - webhook delivery no longer disables TLS verification; the body carries the merchant's shared secret registration: - refuse a username the v3 registrar holds unless the caller's own nostr key is the holder (lib/names.ts) liquid: - honour the deposit kill switch at invoice generation and at credit elements image: - pin 23.3.4 and verify the release tarball checksum Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_0112TGi9GGNWqji1XQ5jZRzc
Diffstat (limited to 'lib/webhooks.ts')
-rw-r--r--lib/webhooks.ts8
1 files changed, 7 insertions, 1 deletions
diff --git a/lib/webhooks.ts b/lib/webhooks.ts
index 2a888991..d724ccdf 100644
--- a/lib/webhooks.ts
+++ b/lib/webhooks.ts
@@ -12,6 +12,13 @@ export const callWebhook = async (invoice, payment) => {
const { amount, confirmed, hash, memo } = payment;
l("calling webhook", webhook, amount, hash, address, text);
+ // TLS verification stays ON. This body carries `secret` — the shared
+ // value the merchant uses to authenticate the notification — so with
+ // rejectUnauthorized:false any party able to intercept the connection
+ // could present its own certificate, harvest the secret, and then forge
+ // "payment received" callbacks to that merchant. A merchant on a
+ // self-signed cert now fails here instead, which the catch below logs;
+ // the payment itself is unaffected.
const res = await got.post(webhook, {
json: {
address,
@@ -23,7 +30,6 @@ export const callWebhook = async (invoice, payment) => {
text,
secret,
},
- https: { rejectUnauthorized: false },
});
return res;
}