A clip in the post a reply answers (the "Replying to" card) goes full screen: a tap on it or its full-screen button used to do nothing, the full-screen handler taking it back out for a media pager that doesn't have it.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_013ZDf1cyCQLkfjftYhymZAg

2 files changed, 106 insertions, 4 deletions

diff --git a/src/features/messages.js b/src/features/messages.js
index 0c69f23..079c22c 100644
--- a/src/features/messages.js
+++ b/src/features/messages.js
@@ -7986,7 +7986,9 @@ export function messagesFeature(ctx) {
     // The player's own full-screen button on a feed clip: the pager, not
     // Chrome's full screen (no next clip there). The button stays on the bar
     // (left off, Chrome greys it out) and is taken over here.
-    if (el && !pager && el.matches && el.matches('.notes-feed video.note-video') && el.dataset.clip) {
+    // (only a clip the pager has: taken out of full screen for a pager that
+    // then wouldn't open, a quoted post's clip went nowhere at all)
+    if (el && !pager && el.matches && el.matches('.notes-feed video.note-video') && el.dataset.clip && clipItem(el, el.dataset.clip)) {
       const url = el.dataset.clip;
       Promise.resolve((document.exitFullscreen || document.webkitExitFullscreen || (() => {})).call(document)).catch(() => {})
         .then(() => { if (!pager && document.contains(el)) openClip(el, url); });
@@ -12425,12 +12427,22 @@ export function messagesFeature(ctx) {
   // (what the player's own full screen did). The screen isn't turned for a
   // wide clip — Adam would rather it play with bars and turn the phone
   // himself — so it follows the phone throughout.
-  function openClip(v, url) {
+  // The pager's item for a clip on the page, if the pager has it: a clip in
+  // the post a reply answers (its "Replying to" card) isn't one of the
+  // feed's own, and gets the browser's full screen instead.
+  function clipItem(v, url) {
     try {
       const on = pageRowOf(v);
-      if (!on) return false;
+      if (!on) return null;
       const it = feedMediaItems(on.c, 'videos').find((x) => (x.row.id === on.rowId || x.ev.id === on.rowId) && x.url === url);
-      if (!it) return false;
+      return it ? { on, it } : null;
+    } catch { return null; }
+  }
+  function openClip(v, url) {
+    try {
+      const found = clipItem(v, url);
+      if (!found) return false;
+      const { on, it } = found;
       tappedClips.add(url); // asked for by hand: no tap-to-play cover
       const at = v.currentTime || 0;
       v.pause();
diff --git a/tools/quoted-clip-fullscreen-test.js b/tools/quoted-clip-fullscreen-test.js
new file mode 100644
index 0000000..bd8dd45
--- /dev/null
+++ b/tools/quoted-clip-fullscreen-test.js
@@ -0,0 +1,90 @@
+// A clip in the post a reply answers (the "Replying to" card in the
+// Conversations view) isn't one of the feed's own, so the media pager can't
+// take it: a tap on it, or the player's own full-screen button, puts it full
+// screen the browser's way. Both used to do nothing at all — the full-screen
+// handler took the clip back out of full screen for a pager that then
+// wouldn't open.
+// Run: bun tools/quoted-clip-fullscreen-test.js
+import puppeteer from './puppeteer.js';
+import { cacheKeyFor } from '../src/wallet.js';
+import { generateSecretKey, getPublicKey, finalizeEvent } from 'nostr-tools/pure';
+import { buildHtml } from '../build.js';
+import { existsSync } from 'node:fs';
+const sleep = (ms) => new Promise((r) => setTimeout(r, ms));
+let ok = true;
+const check = (n, c, d = '') => { console.log(` ${c ? '✓' : '✗'} ${n}${d ? ' — ' + d : ''}`); if (!c) ok = false; };
+const PORT = 5303;
+const CLIP = '/tmp/coinos-quoted-clip.webm';
+if (!existsSync(CLIP)) Bun.spawnSync(['ffmpeg', '-y', '-loglevel', 'error', '-f', 'lavfi', '-i', 'testsrc=size=320x568:rate=10', '-t', '6', '-c:v', 'libvpx', '-b:v', '200k', CLIP]);
+const SKA = generateSecretKey(), ALICE = getPublicKey(SKA), SKB = generateSecretKey(), BOB = getPublicKey(SKB);
+const now = Math.floor(Date.now() / 1000);
+const post = (content, ago, sk, tags = []) => finalizeEvent({ kind: 1, created_at: now - ago, tags, content }, sk);
+const B1 = post(`have you seen this http://localhost:${PORT}/clip.webm`, 400, SKB);
+const R1 = post('alice answers the clip', 200, SKA, [['e', B1.id, '', 'root'], ['p', BOB]]);
+const html = await buildHtml({ minify: true, pwa: false });
+const server = Bun.serve({ port: PORT, fetch: (req) => {
+  const path = new URL(req.url).pathname;
+  if (path === '/clip.webm') return new Response(Bun.file(CLIP), { headers: { 'content-type': 'video/webm' } });
+  if (path.startsWith('/punks')) return new Response(Bun.file('dist' + path));
+  return new Response(html, { headers: { 'content-type': 'text/html' } });
+} });
+const browser = await puppeteer.launch({ executablePath: '/usr/bin/google-chrome', headless: 'new', args: ['--no-sandbox', '--autoplay-policy=no-user-gesture-required'] });
+const page = await browser.newPage();
+const errs = [];
+page.on('pageerror', (e) => errs.push(String(e)));
+const click = (t) => page.evaluate((x) => { const e = [...document.querySelectorAll('button')].find((n) => n.textContent.trim().toLowerCase().includes(x)); if (e) { e.click(); return true; } return false; }, t);
+const waitText = async (x, ms = 25000) => { for (let i = 0; i < ms / 250; i++) { if ((await page.evaluate(() => document.body.innerText)).toLowerCase().includes(x)) return true; await sleep(250); } return false; };
+const waitFor = async (fn, ms = 10000) => { for (let i = 0; i < ms / 100; i++) { if (await page.evaluate(fn)) return true; await sleep(100); } return false; };
+const SEL = '.note-context .quote-card video.note-video';
+const state = () => page.evaluate((sel) => {
+  const v = document.querySelector(sel), fs = document.fullscreenElement;
+  return { fs: fs ? (fs === v ? 'video' : fs.tagName + '.' + fs.className) : null, pager: !!document.querySelector('.media-pager'), thread: !!document.querySelector('.thread-card') };
+}, SEL);
+try {
+  await page.setViewport({ width: 390, height: 844 });
+  await page.goto(`http://localhost:${PORT}/`, { waitUntil: 'domcontentloaded' });
+  await page.evaluate(() => localStorage.setItem('btc-wallet-network', 'regtest'));
+  await page.reload({ waitUntil: 'domcontentloaded' });
+  await sleep(400);
+  await click('create a new wallet'); await sleep(600);
+  await page.waitForSelector('.words .w .t');
+  const mn = (await page.$$eval('.words .w .t', (l) => l.map((e) => e.textContent.trim()))).join(' ');
+  await click('skip verification');
+  await waitText('receive', 20000);
+  const base = cacheKeyFor(mn + '\n');
+  await page.evaluate(([k, alice, bob, roots, replies]) => {
+    localStorage.setItem(k + ':follows', JSON.stringify({ tags: [['p', alice], ['p', bob]], c: '', at: Math.floor(Date.now() / 1000) }));
+    localStorage.setItem(k + ':feedNotes', JSON.stringify(roots));
+    localStorage.setItem(k + ':feedNotes:following~replies', JSON.stringify(replies));
+    localStorage.setItem(k + ':profiles', JSON.stringify({ [alice]: { name: 'Alice', t: Date.now() }, [bob]: { name: 'Bob', t: Date.now() } }));
+    localStorage.setItem('btc-wallet-feed:' + k, 'following');
+  }, [base, ALICE, BOB, [B1], [R1]]);
+  await page.reload({ waitUntil: 'domcontentloaded' });
+  await waitText('receive', 20000);
+  await page.evaluate(() => document.querySelector('.app-nav-button[aria-label="Feed"]').click());
+  await waitFor(() => !!document.querySelector('.media-mode[data-mode="replies"]'), 20000);
+  await page.evaluate(() => document.querySelector('.media-mode[data-mode="replies"]').click());
+  check('the reply shows the clip in its "Replying to" card', await waitFor(() => !!document.querySelector('.note-context .quote-card video.note-video'), 20000));
+  await page.evaluate((sel) => document.querySelector(sel).scrollIntoView({ block: 'center' }), SEL);
+  await sleep(800);
+
+  console.log('\n[a tap on the picture]');
+  const box = await (await page.$(SEL)).boundingBox();
+  await page.mouse.click(box.x + box.width / 2, box.y + box.height * 0.25); // above the middle: not the play button
+  check('the clip goes full screen', await waitFor(() => document.fullscreenElement && document.fullscreenElement.matches('video'), 4000), JSON.stringify(await state()));
+  await sleep(600);
+  check('...and stays there (not taken back out)', (await state()).fs === 'video', JSON.stringify(await state()));
+  check('...and no thread opened under it', !(await state()).thread);
+  await page.evaluate(() => document.exitFullscreen());
+  await waitFor(() => !document.fullscreenElement, 3000);
+
+  console.log('\n[the player\'s full-screen button]');
+  await page.evaluate((sel) => document.querySelector(sel).requestFullscreen(), SEL); // as the ⛶ on its bar does
+  await sleep(800);
+  check('full screen, and it stays', (await state()).fs === 'video', JSON.stringify(await state()));
+  check('no page errors', !errs.length, errs.join(' | '));
+} catch (e) { console.error(e); ok = false; } finally {
+  await browser.close(); server.stop(true);
+}
+console.log(ok ? '\n✅ a quoted post\'s clip goes full screen' : '\n❌ failed');
+process.exit(ok ? 0 : 1);