Notifications: tapping a zap with no post behind it does something. A zap on your profile opens the zapper's profile, and a zap on a stream opens the stream. The tap used to do nothing, because the row only knew how to open a post.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_013ZDf1cyCQLkfjftYhymZAg

2 files changed, 13 insertions, 1 deletions

diff --git a/src/features/messages.js b/src/features/messages.js
index 13e328a..6692ddc 100644
--- a/src/features/messages.js
+++ b/src/features/messages.js
@@ -17077,7 +17077,9 @@ export function messagesFeature(ctx) {
     if (ZAP_KINDS.includes(ev.kind)) {
       const actor = zapperOf(ev), sats = receiptSats(ev);
       if (!actor || my.includes(actor) || !sats) return null;
-      return { id: ev.id, what: 'zap', actor, target: lastE, hint, sats, text: zapText(ev), ts: ev.created_at };
+      // a zap on a stream names it by address (a 30311), not by an e tag
+      const stream = !lastE ? ((ev.tags || []).find((x) => x[0] === 'a' && String(x[1] || '').startsWith(LIVE_KIND + ':')) || [])[1] || null : null;
+      return { id: ev.id, what: 'zap', actor, target: lastE, stream, hint, sats, text: zapText(ev), ts: ev.created_at };
     }
     if (my.includes(ev.pubkey)) return null;
     if (ev.kind === 7) {
@@ -17266,6 +17268,10 @@ export function messagesFeature(ctx) {
         if (target) openNoteThread(target);
         // a note we couldn't find is asked for again on tap, hints and all
         else if (x.target) openNoteRef({ id: x.target, relays: x.hint || [] }).catch(() => {});
+        // a zap on a stream opens the stream; one on your profile (no post
+        // at all) opens the zapper's — the tap used to do nothing
+        else if (x.stream) { const [, pk, ...d] = x.stream.split(':'); stopNotifWatch(); openLiveRef({ pk, d: d.join(':') }).catch(() => {}); }
+        else { stopNotifWatch(); openProfile(x.actor); }
       }
     };
     return h('div', {
diff --git a/tools/notif-faces-test.js b/tools/notif-faces-test.js
index b45b120..a1c1c8f 100644
--- a/tools/notif-faces-test.js
+++ b/tools/notif-faces-test.js
@@ -73,6 +73,8 @@ try {
   const ME = getPublicKey(privateKeyFromSeedWords(mn));
   // a cached notifications list: five people reacted to my post
   const items = ACTORS.map((a, i) => ({ id: 'r'.repeat(63) + i, what: 'react', actor: a.pk, target: 't'.repeat(64), hint: [], emoji: '❤️', ts: now - 60 * (i + 1) }));
+  // and one zapped my profile: no post to open
+  items.unshift({ id: 'z'.repeat(64), what: 'zap', actor: ACTORS[1].pk, target: null, hint: [], sats: 421, text: 'thanks!', ts: now - 30 });
   await page.evaluate(([k, me, items]) => {
     const st = JSON.parse(localStorage.getItem(k + ':messages') || '{}');
     st.notifs = items; st.notifsPk = me; st.notifsV = 2;
@@ -100,6 +102,10 @@ try {
   await sleep(150); // the first paint, not a settled one
   const faces = await page.evaluate(() => [...document.querySelectorAll('.notes-feed .chat-avatar')].map((a) => a.classList.contains('ava-img') || (a.style.backgroundImage || '').includes('url')));
   check('every row paints with a face on the first frame', faces.length >= 5 && faces.every(Boolean), JSON.stringify(faces));
+  // a zap on my profile (no post): the tap opens the zapper's profile — it did nothing
+  await page.evaluate(() => [...document.querySelectorAll('.alert-row')].find((r) => r.textContent.includes('thanks!')).querySelector('.grow').click());
+  await sleep(500);
+  check('tapping a profile zap opens the zapper\'s profile', await page.evaluate((pk) => !document.querySelector('.alert-row') && /npub1|nprofile1/.test(location.pathname) && document.body.innerText.includes('Actor 1'), ACTORS[1].pk), await page.evaluate(() => location.pathname));
   check('no page errors', errs.length === 0, errs.slice(0, 2).join(' | '));
 } finally { await browser.close(); server.stop(true); }
 console.log(ok ? '\n✅ notifications open with their faces on' : '\n❌ failed');