Features phase 2b: silent payments + nostr sync leave the core wallet

wallet.js drops from 2,374 to ~1,970 lines, holding only BIP84 on-chain
logic plus generic feature seams. New seams added this pass:
  registerBalanceExtra   extra confirmed/pending buckets
  registerInputProvider  extra spendable inputs for buildTx
  registerSendPreparer   destinations needing post-selection derivation
  registerInputSigner    non-BIP84 input signing
  registerHistoryProvider / registerScanHook / registerRealtimeHook /
  registerLoadHook / registerCacheExtension / registerCacheSavedHook

src/features/sp-wallet.js: the whole BIP-352 engine — key derivation,
worker-accelerated indexer scanning, the live indexer WebSocket, SP
outputs as spendable inputs, sp1 send preparation, and per-output-key
signing — installs via those seams (installSpWallet).

src/features/sync.js: nostr identity + encrypted cross-device state sync
plus its Settings card, installed via load/cache-saved/realtime hooks.
profileChip/nostrProfile move here-adjacent (into gifts, the only other
nostr consumer), so core app.js no longer imports nostr at all.

buildTx/sign are now feature-agnostic (input providers + preparers +
signers); _recomputeBalance* use the balance-extra registry, so a core
build with no SP no longer calls a missing spBalance() (that regression
dropped the minimal build into offline mode — caught by the smoke test).

New coverage: tools/sp-test.js drives two browser "devices" through an
SP send, indexer discovery, and an SP-input spend on the ark regtest
chain (needs tools/sp-indexer.js pointed at bitcoind:18543). Minimal
smoke now also asserts no SP/nostr code ships.

Minimal profile: 314KB, down from 412KB (full: 580KB). All suites green:
minimal smoke, sp-test, ark UI, gift lifecycle.

Co-Authored-By: Claude Fable 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01QFAcD4V284DvYZZHP7Rxxy

1 files changed, 2 insertions, 0 deletions

diff --git a/src/features/sp.js b/src/features/sp.js
index 0960cdf..5c55457 100644
--- a/src/features/sp.js
+++ b/src/features/sp.js
@@ -3,12 +3,14 @@
 // in wallet.js/silentpay.js and ships with the core wallet for now.)
 
 import { isSilentPaymentAddress } from '../silentpay.js';
+import { installSpWallet } from './sp-wallet.js';
 import { getNetwork, getSpIndexerConfig, setSpIndexerConfig, spIndexerPresets } from '../api.js';
 import { t } from '../i18n.js';
 import { qrSvg } from '../qr.js';
 
 export function spFeature(ctx) {
   const { h, ui, render, wallet, copyBtn } = ctx;
+  installSpWallet(wallet); // the BIP-352 engine lives outside the core wallet
 
   function spIndexerCard() {
     if (!wallet.silentPaymentKeys || !wallet.silentPaymentKeys()) return null;