Video tiles: a frame even when the size check fails; retry it later

Efrat's clip (blossom.primal.net → r2a.primal.net) showed a blank tile on
a phone: the 64 KB probe failed there (slow connection), the failure was
kept for good, and a tile with a failed probe never tried for a frame.

- A failed probe is dated and asked again after an hour (it was kept
  forever; old 'failed: true' entries are retried). The probe waits 10 s.
- A tile whose probe failed still tries for a first frame, giving up and
  letting go of the file after 8 s.
- Primal's CDN lets scripts read the bytes but not Content-Range, so the
  size was unknown: a HEAD's Content-Length (readable by any page) fills
  it in.
- No size in imeta but a bitrate and duration (Primal posts those): the
  size is estimated from them. 'dim 1080.0x1920.0' is understood.
- A tile with nothing to show is dark, like a video, not a pale gap.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01ULQZS9MQa6iAsXnrJUD9Du

1 files changed, 27 insertions, 10 deletions

diff --git a/tools/feed-media-cache-test.js b/tools/feed-media-cache-test.js
index 08c679e..a1e0017 100644
--- a/tools/feed-media-cache-test.js
+++ b/tools/feed-media-cache-test.js
@@ -14,28 +14,33 @@ let ok = true;
 const check = (n, c, d = '') => { console.log(` ${c ? '✓' : '✗'} ${n}${d ? ' — ' + d : ''}`); if (!c) ok = false; };
 const dir = mkdtempSync(tmpdir() + '/mcache-');
 const ff = (args) => { const p = Bun.spawnSync(['ffmpeg', '-y', '-loglevel', 'error', ...args]); if (p.exitCode !== 0) throw new Error('ffmpeg failed'); };
-for (const n of ['v1', 'v2', 'v3']) ff(['-f', 'lavfi', '-i', 'testsrc=size=360x640:rate=10', '-t', '2', '-c:v', 'libx264', '-pix_fmt', 'yuv420p', '-movflags', '+faststart', `${dir}/${n}.mp4`]);
+for (const n of ['v1', 'v2', 'v3', 'h4', 'n5']) ff(['-f', 'lavfi', '-i', 'testsrc=size=360x640:rate=10', '-t', '2', '-c:v', 'libx264', '-pix_fmt', 'yuv420p', '-movflags', '+faststart', `${dir}/${n}.mp4`]);
 ff(['-f', 'lavfi', '-i', 'testsrc=size=800x600', '-frames:v', '1', `${dir}/slow.jpg`]);
 
 const html = await buildHtml({ minify: true, pwa: false });
 const server = Bun.serve({ port: 0, idleTimeout: 30, fetch: async (req) => {
   const path = new URL(req.url).pathname;
   const cors = { 'access-control-allow-origin': '*', 'access-control-expose-headers': 'content-range, content-length' };
-  if (path.startsWith('/v/')) {
+  // /h/: like Primal's, scripts may read the bytes but not Content-Range;
+  // /n/: no CORS at all (a player may show it, a script can't read it)
+  if (path.startsWith('/v/') || path.startsWith('/h/') || path.startsWith('/n/')) {
     const f = Bun.file(dir + path.slice(2));
+    const head = path.startsWith('/v/') ? cors : path.startsWith('/h/') ? { 'access-control-allow-origin': '*' } : {};
+    if (req.method === 'HEAD') return new Response(null, { headers: { ...head, 'content-type': 'video/mp4', 'content-length': String(f.size) } });
     const m = /bytes=(\d+)-(\d*)/.exec(req.headers.get('range') || '');
     if (m) {
       const a = +m[1], b = Math.min(m[2] ? +m[2] : f.size - 1, f.size - 1);
-      return new Response(f.slice(a, b + 1), { status: 206, headers: { ...cors, 'content-type': 'video/mp4', 'content-range': `bytes ${a}-${b}/${f.size}`, 'accept-ranges': 'bytes' } });
+      return new Response(f.slice(a, b + 1), { status: 206, headers: { ...head, 'content-type': 'video/mp4', 'content-range': `bytes ${a}-${b}/${f.size}`, 'accept-ranges': 'bytes' } });
     }
-    return new Response(f, { headers: { ...cors, 'content-type': 'video/mp4' } });
+    return new Response(f, { headers: { ...head, 'content-type': 'video/mp4' } });
   }
   // a picture that takes ten seconds: the crawl must not wait on it
   if (path === '/i/slow.jpg') { await sleep(10000); return new Response(Bun.file(dir + '/slow.jpg'), { headers: { 'content-type': 'image/jpeg' } }); }
   if (path.startsWith('/punks') || path === '/verify-worker.js') return new Response(Bun.file('dist' + path));
   return new Response(html, { headers: { 'content-type': 'text/html' } });
 } });
-const base = server.url.origin;
+const page0 = server.url.origin;
+const base = page0.replace('localhost', '127.0.0.1'); // the media lives on another origin, as it does for real
 const SK = generateSecretKey(), PK = getPublicKey(SK);
 const now = Math.floor(Date.now() / 1000);
 const post = (i, content) => finalizeEvent({ kind: 1, created_at: now - 100 - i * 60, tags: [], content }, SK);
@@ -48,6 +53,11 @@ for (let i = 42; i < 60; i++) all.push(post(i, 'more words ' + i));
 all.push(post(60, 'second clip ' + base + '/v/v2.mp4'));
 for (let i = 61; i < 150; i++) all.push(post(i, 'deep words ' + i));
 all.push(post(150, 'third clip, far down ' + base + '/v/v3.mp4'));
+// the shape from imeta (the probe can't read it from either host)
+const tagged = (i, content, url) => finalizeEvent({ kind: 1, created_at: now - 100 - i * 60, content,
+  tags: [['imeta', 'url ' + url, 'm video/mp4', 'dim 1080.0x1920.0', 'duration 2.0', 'bitrate 48000']] }, SK);
+all.push(tagged(151, 'size hidden ' + base + '/h/h4.mp4', base + '/h/h4.mp4'));
+all.push(tagged(152, 'no cors ' + base + '/n/n5.mp4', base + '/n/n5.mp4'));
 
 const browser = await puppeteer.launch({ executablePath: process.env.CHROME || '/usr/bin/google-chrome', headless: 'new', args: ['--no-sandbox', '--autoplay-policy=no-user-gesture-required'] });
 const page = await browser.newPage();
@@ -94,7 +104,7 @@ const openFeed = async () => {
 
 try {
   await page.setViewport({ width: 390, height: 844 });
-  await page.goto(base, { waitUntil: 'domcontentloaded' });
+  await page.goto(page0, { waitUntil: 'domcontentloaded' });
   await page.evaluate(() => localStorage.setItem('btc-wallet-network', 'regtest'));
   await page.reload({ waitUntil: 'domcontentloaded' }); await sleep(400);
   await click('create a new wallet'); await sleep(600);
@@ -117,14 +127,21 @@ try {
   console.log('\n[a crawl straight into the media index]');
   const t0 = Date.now();
   await page.evaluate(() => { window.__reqs = []; document.querySelector('.media-mode[data-mode="videos"]').click(); });
-  check('all three clips are found, the deepest 150 posts down', await waitFor(() => document.querySelectorAll('.media-grid .media-tile.video').length === 3, 15000), String(await tiles()));
+  check('all five clips are found, the deepest 150 posts down', await waitFor(() => document.querySelectorAll('.media-grid .media-tile.video').length === 5, 15000), String(await tiles()));
   const took = Date.now() - t0;
   check('...without waiting on the slow picture along the way', took < 8000, took + ' ms');
   const reqs = await page.evaluate(() => window.__reqs);
   const steps = [...new Set(reqs.map((r) => r.until))]; // each step asks every relay
   check('...asking a hundred posts at a time, each step older than the last', reqs.length >= 1 && reqs.every((r) => r.limit === 100 && r.until)
     && steps.every((u, i) => !i || u < steps[i - 1]), JSON.stringify(steps));
-  check('tile frames are kept as pictures', await waitFor(async () => (await (await caches.open('coinos-video-thumbs-v1')).keys()).length === 3, 8000));
+  check('tile frames are kept as pictures (all but the no-CORS host\'s)', await waitFor(async () => (await (await caches.open('coinos-video-thumbs-v1')).keys()).length === 4, 8000));
+  await waitFor(() => /h4\.mp4[^\]]*probed|probed[^\]]*h4/.test(localStorage.getItem('coinos-video-info') || '') && /n5\.mp4[^\]]*failed/.test(localStorage.getItem('coinos-video-info') || ''), 8000); // the write-behind
+  const info = await page.evaluate(() => Object.fromEntries(JSON.parse(localStorage.getItem('coinos-video-info') || '[]').map(([u, d]) => [u.split('/').pop(), d])));
+  check('a host hiding Content-Range gives its size to a HEAD', info['h4.mp4']?.probed && info['h4.mp4'].size > 1000 && info['h4.mp4'].size !== 12000, JSON.stringify(info['h4.mp4']));
+  check('a host refusing the probe still gets a frame in its tile', await page.evaluate(() => {
+    const v = [...document.querySelectorAll('.media-tile video')].find((x) => /n5/.test(x.getAttribute('data-src')));
+    return !!v && v.readyState >= 2 && v.videoWidth > 0; }), JSON.stringify(info['n5.mp4']));
+  check('...and its failure is dated, to be asked again later', typeof info['n5.mp4']?.failed === 'number');
   await sleep(2000); // the index's write-behind
 
   console.log('\n[a reload]');
@@ -133,8 +150,8 @@ try {
   await page.evaluate(() => { window.__reqs = []; });
   const t1 = Date.now();
   await openFeed();
-  check('the grid paints from the index at once', await waitFor(() => document.querySelectorAll('.media-grid .media-tile.video').length === 3, 4000), (Date.now() - t1) + ' ms');
-  check('...its tiles pictures from the kept frames, no player needed', await waitFor(() => [...document.querySelectorAll('.media-grid .media-tile.video img')].filter((i) => i.src.startsWith('blob:')).length === 3, 4000));
+  check('the grid paints from the index at once', await waitFor(() => document.querySelectorAll('.media-grid .media-tile.video').length === 5, 4000), (Date.now() - t1) + ' ms');
+  check('...its tiles pictures from the kept frames, no player needed', await waitFor(() => [...document.querySelectorAll('.media-grid .media-tile.video img')].filter((i) => i.src.startsWith('blob:')).length === 4, 4000));
   await sleep(2500);
   const after = await page.evaluate(() => window.__reqs.filter((r) => r.limit === 100));
   const deepest = all.find((e) => /far down/.test(e.content)).created_at;