1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
|
// A rejected package must reject send(), retain the unspent inputs, and
// appear as a failed attempt rather than a successful payment.
// Run: bun tools/ark/send-failure-test.js
import assert from 'node:assert/strict';
import { mock } from 'bun:test';
import { secp256k1 } from '@noble/curves/secp256k1';
import { encodeAddress, GrpcError } from '../../src/ark/proto.js';
const send = await import('../../src/ark/send.js');
let cosigns = 0;
const badId = 'a'.repeat(64) + ':0';
const error = new GrpcError(3, `bad user input: vtxo ${badId} expired at height 100 (tip = 200)`, 'RequestArkoorCosign');
let nextError = error;
mock.module('../../src/ark/send.js', () => ({
...send,
registerVtxoTransactions: async () => {},
buildArkoorSend: () => ({}),
cosignPackageWithServer: async () => { cosigns++; throw nextError; },
}));
const { ArkManager } = await import('../../src/ark/manager.js');
const key = n => secp256k1.getPublicKey(new Uint8Array(32).fill(n), true);
const dest = encodeAddress({ testnet: true, serverPubkey: key(1), userPubkey: key(2), blindedMailboxId: new Uint8Array(32).fill(3) });
const mgr = new ArkManager({ storage: { save() {} }, arkUrl: 'http://test.invalid' });
mgr.serverPub = key(1);
mgr.state = {
nextKeyIndex: 1, movements: [], actions: [],
vtxos: [
{ id: badId, amountSat: 1, expiryHeight: 100, state: 'spendable' },
{ id: 'b'.repeat(64) + ':0', amountSat: 180, expiryHeight: 500, state: 'spendable' },
],
};
Object.defineProperty(mgr, 'chain', { value: { tipHeight: async () => 200 } });
mgr._decoded = () => ({ _raw: { bytes: new Uint8Array() } });
mgr._keyForVtxo = () => ({});
// the refusal marks the coin and the send goes again on what is left —
// here nothing covers 181, so the user hears about the shortfall
await assert.rejects(mgr.send(dest, 181), /1 sat expired and unusable/);
assert.equal(cosigns, 1, 'the retry does not reuse the rejected coin');
assert.equal(mgr.state.actions[0].step, 'failed');
assert.ok(mgr.state.vtxos.every(v => v.state === 'spendable'), 'atomic rejection does not consume either input');
assert.deepEqual(mgr.balance(), { spendableSat: 180, pendingSat: 0, boardingSat: 0, expiredSat: 1 });
assert.equal(mgr.state.movements.length, 0, 'the retried attempt leaves no failed row');
assert.equal(mgr.pendingActions().length, 0, 'a definitive rejection is not driven again');
console.log('✓ an expired-input rejection retries without the coin and preserves unspent inputs');
// any other refusal still surfaces at once and is recorded
nextError = new GrpcError(3, 'bad user input: something else', 'RequestArkoorCosign');
await assert.rejects(mgr.send(dest, 180), /something else/);
assert.equal(cosigns, 2, 'no retry for other refusals');
assert.equal(mgr.state.movements[0].status, 'failed');
assert.equal(mgr.state.movements[0].to, dest);
console.log('✓ other rejections throw once and record failure');
nextError = error;
assert.equal(mgr._selectInputs(180, 200)[0].amountSat, 180);
assert.equal(mgr._expired({ amountSat: 1, expiryHeight: 100 }, 200), false, 'other dust retains its existing policy');
delete mgr.state.vtxos[0].expiryRejected;
assert.equal(mgr._recordExpiryRejection(mgr.state.actions[0]), true);
assert.equal(mgr.balance().spendableSat, 180, 'old failed actions repair the displayed balance');
assert.equal(mgr._recordExpiryRejection(mgr.state.actions[0]), false, 'repair is idempotent');
assert.equal(mgr._recordExpiryRejection({ ...mgr.state.actions[0], parts: [] }), false, 'only inputs of that failed action can be marked');
console.log('✓ known expired inputs stay excluded after reload; the usable 180 sats remain selectable');
mgr._driveSend = async action => { action.step = 'done'; };
assert.match(await mgr.send(dest, 180), /^send-/);
console.log('✓ a completed send still returns its action ID');
const { arkFeature } = await import('../../src/features/ark.js');
const h = (tag, props, ...children) => ({ tag, props, children: children.flat().filter(x => x != null && x !== false) });
const text = n => typeof n === 'object' ? n.children.map(text).join('') : String(n);
const feature = arkFeature({ h, ui: {}, render() {}, fmtAmount: String, unitLabel: () => 'sats', hook: () => null,
wallet: { registerCacheExtension() {}, loadFeatureState: () => ({}) } });
const rows = feature._histBuild({ movements: [{ id: 'failed-send', type: 'send', status: 'failed', amountSat: 181, ts: Date.now() }], actions: [], vtxos: [] });
assert.equal(rows.length, 1);
const label = text(rows[0].render());
assert.match(label, /Payment failed/);
assert.ok(!label.includes('-181'), 'a rejected amount is not displayed as money spent');
console.log('✓ history includes the failed attempt without claiming a debit');
process.exit(0);
|
